chore(updatecli): Adds documentation to the script and enhances the jq command.
#914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
changed the title
jq command.jq command.
dduportal
changed the title
jq command.jq command.
dduportal
previously approved these changes
Dec 2, 2024
Contributor
dduportal
left a comment
dduportal
left a comment
There was a problem hiding this comment.
Checks says:
✔ Bump UBI9 version:
Source:
✔ [latestVersion] Get the latest UBI9 Linux version
Condition:
✔ [checkUbi9DockerImage] Check if the container image "ubi9" is available
Target:
✔ [updateDockerBake] Update the default value of the variable UBI9_TAG in the docker-bake.hcl
✔ [updateDockerfile] Update the value of the base image (ARG UBI9_TAG) in the Dockerfile
That looks good to me!
Let's have a secondary review by @lemeurherve as he asked for some of these changes in previous PRs
Contributor
lemeurherveCB
left a comment
lemeurherveCB
left a comment
There was a problem hiding this comment.
Thanks for the follow-up!
Some suggestions below.
Thanks for the review! Co-authored-by: lemeurherveCB <[email protected]>
Contributor
|
Reposting a comment from an automatically hidden thread:
remark(not concerning this PR): a doc for RedHat API? If so, I don't think it has a place in this repo as it's not a core part of Jenkins agents, I would suggest not spending time on this. |
Co-authored-by: lemeurherveCB <[email protected]>
MarkEWaite
approved these changes
Dec 7, 2024
dduportal
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #907.
I refined the tag selection logic in
jqby implementing a filter for tags containing hyphens.To enhance code understanding, I added explanatory comments that provide additional context about the data retrieved from the RedHat REST API.
A comprehensive markdown documentation detailing the API's functionality is currently in development and will be included in an upcoming pull request.
Testing done
Submitter checklist